When forming questions in English, remember that the verb usually precedes the subject in yes/no questions. In WH-questions, the question word comes first.
The correct sentence with the right word order is "What is your favourite colour?" It follows the standard structure for forming a question with the subject after the verb "is."